Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildPanel.js DOM text reinterpreted as HTML #94

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Shivam7-1
Copy link

By using textContent, it will avoid the risk of HTML injection, as these properties automatically escape any HTML special characters in the provided text. This helps prevent cross-site scripting (XSS) vulnerabilities by treating the input as plain text rather than interpreted HTML.

@Shivam7-1
Copy link
Author

Hi @pzread Could You Please Review This PR
Thanks

@Shivam7-1
Copy link
Author

Hi @antiagainst Could You Please Review This PR
Thanks

@Shivam7-1
Copy link
Author

Hi @pzread Could You Please Review This PR
Thanks

@Shivam7-1
Copy link
Author

Hi @antiagainst Could You Please Review This PR
Thanks

@Shivam7-1
Copy link
Author

Hi @antiagainst Thanks For Reviewing
Above PR was approved recently, and I wanted to check in if there's anything else needed from my side to proceed with the merge.

Thanks

@Shivam7-1
Copy link
Author

Hi @antiagainst Thanks For Reviewing
Is there's anything else needed from my side to proceed with the merge.

Thanks

@Shivam7-1 Shivam7-1 requested a review from antiagainst May 8, 2024 02:45
@antiagainst
Copy link
Contributor

Thanks! It looks I don't have write access anymore. Need somebody from Google to land it.

@Shivam7-1
Copy link
Author

Hi @antiagainst Thanks For Reviewing
Is there Anyone You Know Who Can merge it ?
Thanks

@Shivam7-1
Copy link
Author

Hi @pzread Could You Please Merge This PR
As it is Approved
Thanks

@pzread
Copy link

pzread commented May 12, 2024

Hi @Shivam7-1 , I also no longer have merge access

@Shivam7-1
Copy link
Author

Hi @pzread Thanks For Replying
Is there Any Chance Do You Know who is Managing This Repo?
Thanks

@pzread
Copy link

pzread commented May 12, 2024

Hi @pzread Thanks For Replying Is there Any Chance Do You Know who is Managing This Repo? Thanks

No unfortunately.

@Shivam7-1
Copy link
Author

Hi @pzread Thanks For Replying Is there Any Chance Do You Know who is Managing This Repo? Thanks

No unfortunately.

Okay Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants