Move JDK toolchain, Kotlin language and JVM target configuration to convention plugin. #4559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
|
ในวันที่ พฤ. 2 ม.ค. 2025 22:40 น. copybara-service[bot] <
***@***.***> เขียนว่า:
… Move JDK toolchain, Kotlin language and JVM target configuration to
convention plugin.
Also trying to keep libs.versions.toml ordered alphabetically.
RELNOTES=N/A
------------------------------
You can view, comment on, or merge this pull request online at:
#4559
Commit Summary
- 3b9750f
<3b9750f>
Move JDK toolchain, Kotlin language and JVM target configuration to
convention plugin.
File Changes
(5 files <https://github.com/google/dagger/pull/4559/files>)
- *M* buildSrc/build.gradle.kts
<https://github.com/google/dagger/pull/4559/files#diff-7b5c40eb5522b5216cfe8c75612e579a8db0daee9ded80df9ce6a56e8361a962>
(15)
- *A*
buildSrc/src/main/kotlin/dagger/gradle/build/KotlinJvmConventionPlugin.kt
<https://github.com/google/dagger/pull/4559/files#diff-28b2c98fc21a172a2afa1a26ec6698fb51aaedf21d3ba7e6386ee394c103996f>
(42)
- *A* buildSrc/src/main/kotlin/dagger/gradle/build/VersionCatalogs.kt
<https://github.com/google/dagger/pull/4559/files#diff-a6f11ce430a37c781c338de3b6779f71a7f7705653df8127afa58b7e1c577c6e>
(33)
- *M* gradle-projects/dagger-runtime/build.gradle.kts
<https://github.com/google/dagger/pull/4559/files#diff-851c010c4b04d65e1b6ca6fafc26b4f79afc461fdaba2b6c04614631f651ce4c>
(13)
- *M* gradle/libs.versions.toml
<https://github.com/google/dagger/pull/4559/files#diff-697f70cdd88ba88fe77eebda60c7e143f6ad1286bca75017421e93ad84fb87df>
(12)
Patch Links:
- https://github.com/google/dagger/pull/4559.patch
- https://github.com/google/dagger/pull/4559.diff
—
Reply to this email directly, view it on GitHub
<#4559>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BDAAXVLC4YIKGWHNTOGOHZT2IVMVZAVCNFSM6AAAAABUQFKCWKVHI2DSMVQWIX3LMV43ASLTON2WKOZSG43DMMRTGY4DOMI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
💖
จรัส ส่งรีแอ็กชันผ่าน Gmail
<https://www.google.com/gmail/about/?utm_source=gmail-in-product&utm_medium=et&utm_campaign=emojireactionemail#app>
ในวันที่ ศ. 3 ม.ค. 2025 00:31 น. จรัส อ๊อดเดช <
***@***.***> เขียนว่า:
…
ในวันที่ พฤ. 2 ม.ค. 2025 22:40 น. copybara-service[bot] <
***@***.***> เขียนว่า:
> Move JDK toolchain, Kotlin language and JVM target configuration to
> convention plugin.
>
> Also trying to keep libs.versions.toml ordered alphabetically.
>
> RELNOTES=N/A
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #4559
> Commit Summary
>
> - 3b9750f
> <3b9750f>
> Move JDK toolchain, Kotlin language and JVM target configuration to
> convention plugin.
>
> File Changes
>
> (5 files <https://github.com/google/dagger/pull/4559/files>)
>
> - *M* buildSrc/build.gradle.kts
> <https://github.com/google/dagger/pull/4559/files#diff-7b5c40eb5522b5216cfe8c75612e579a8db0daee9ded80df9ce6a56e8361a962>
> (15)
> - *A*
> buildSrc/src/main/kotlin/dagger/gradle/build/KotlinJvmConventionPlugin.kt
> <https://github.com/google/dagger/pull/4559/files#diff-28b2c98fc21a172a2afa1a26ec6698fb51aaedf21d3ba7e6386ee394c103996f>
> (42)
> - *A* buildSrc/src/main/kotlin/dagger/gradle/build/VersionCatalogs.kt
> <https://github.com/google/dagger/pull/4559/files#diff-a6f11ce430a37c781c338de3b6779f71a7f7705653df8127afa58b7e1c577c6e>
> (33)
> - *M* gradle-projects/dagger-runtime/build.gradle.kts
> <https://github.com/google/dagger/pull/4559/files#diff-851c010c4b04d65e1b6ca6fafc26b4f79afc461fdaba2b6c04614631f651ce4c>
> (13)
> - *M* gradle/libs.versions.toml
> <https://github.com/google/dagger/pull/4559/files#diff-697f70cdd88ba88fe77eebda60c7e143f6ad1286bca75017421e93ad84fb87df>
> (12)
>
> Patch Links:
>
> - https://github.com/google/dagger/pull/4559.patch
> - https://github.com/google/dagger/pull/4559.diff
>
> —
> Reply to this email directly, view it on GitHub
> <#4559>, or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BDAAXVLC4YIKGWHNTOGOHZT2IVMVZAVCNFSM6AAAAABUQFKCWKVHI2DSMVQWIX3LMV43ASLTON2WKOZSG43DMMRTGY4DOMI>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
|
|
😀
จรัส ส่งรีแอ็กชันผ่าน Gmail
<https://www.google.com/gmail/about/?utm_source=gmail-in-product&utm_medium=et&utm_campaign=emojireactionemail#app>
ในวันที่ ศ. 3 ม.ค. 2025 00:31 น. จรัส อ๊อดเดช <
***@***.***> เขียนว่า:
…
ในวันที่ พฤ. 2 ม.ค. 2025 22:40 น. copybara-service[bot] <
***@***.***> เขียนว่า:
> Move JDK toolchain, Kotlin language and JVM target configuration to
> convention plugin.
>
> Also trying to keep libs.versions.toml ordered alphabetically.
>
> RELNOTES=N/A
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #4559
> Commit Summary
>
> - 3b9750f
> <3b9750f>
> Move JDK toolchain, Kotlin language and JVM target configuration to
> convention plugin.
>
> File Changes
>
> (5 files <https://github.com/google/dagger/pull/4559/files>)
>
> - *M* buildSrc/build.gradle.kts
> <https://github.com/google/dagger/pull/4559/files#diff-7b5c40eb5522b5216cfe8c75612e579a8db0daee9ded80df9ce6a56e8361a962>
> (15)
> - *A*
> buildSrc/src/main/kotlin/dagger/gradle/build/KotlinJvmConventionPlugin.kt
> <https://github.com/google/dagger/pull/4559/files#diff-28b2c98fc21a172a2afa1a26ec6698fb51aaedf21d3ba7e6386ee394c103996f>
> (42)
> - *A* buildSrc/src/main/kotlin/dagger/gradle/build/VersionCatalogs.kt
> <https://github.com/google/dagger/pull/4559/files#diff-a6f11ce430a37c781c338de3b6779f71a7f7705653df8127afa58b7e1c577c6e>
> (33)
> - *M* gradle-projects/dagger-runtime/build.gradle.kts
> <https://github.com/google/dagger/pull/4559/files#diff-851c010c4b04d65e1b6ca6fafc26b4f79afc461fdaba2b6c04614631f651ce4c>
> (13)
> - *M* gradle/libs.versions.toml
> <https://github.com/google/dagger/pull/4559/files#diff-697f70cdd88ba88fe77eebda60c7e143f6ad1286bca75017421e93ad84fb87df>
> (12)
>
> Patch Links:
>
> - https://github.com/google/dagger/pull/4559.patch
> - https://github.com/google/dagger/pull/4559.diff
>
> —
> Reply to this email directly, view it on GitHub
> <#4559>, or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BDAAXVLC4YIKGWHNTOGOHZT2IVMVZAVCNFSM6AAAAABUQFKCWKVHI2DSMVQWIX3LMV43ASLTON2WKOZSG43DMMRTGY4DOMI>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
|
copybara-service
bot
force-pushed
the
test_711420159
branch
2 times, most recently
from
bf328f3 to
12975b4
Compare
…onvention plugin. Also trying to keep libs.versions.toml ordered alphabetically. RELNOTES=N/A PiperOrigin-RevId: 711866498
copybara-service
bot
force-pushed
the
test_711420159
branch
from
12975b4 to
3418609
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move JDK toolchain, Kotlin language and JVM target configuration to convention plugin.
Also trying to keep libs.versions.toml ordered alphabetically.
RELNOTES=N/A