Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code examples in the Dagger tutorials #4509

Merged
merged 1 commit into from
Nov 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tutorial/01-setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ class CommandLineAtm {
CommandRouter commandRouter = new CommandRouter();

while (scanner.hasNextLine()) {
Status unused = commandRouter.route(scanner.nextLine());
Result unused = commandRouter.route(scanner.nextLine());
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion tutorial/02-initial-dagger.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class CommandLineAtm {
CommandRouter commandRouter = commandRouterFactory.router();

while (scanner.hasNextLine()) {
Status unused = commandRouter.route(scanner.nextLine());
Result unused = commandRouter.route(scanner.nextLine());
}
}
}
Expand Down
8 changes: 6 additions & 2 deletions tutorial/14-avoiding-recursive-logins.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ final class LoginCommand extends SingleArgCommand {
if (account.isPresent()) {
// Ignore "login <foo>" commands if we already have an account
return Result.handled();
} else {
Account account = database.getAccount(username);
UserCommandsRouter userCommands = userCommandsRouterFactory.create(account);
return Result.enterNestedCommandSet(userCommands.router());
}
}
}
Expand All @@ -52,11 +56,11 @@ In order to tell Dagger how to supply this `Optional<Account>`, let's add a

```java
@Module
interface LoginCommandModule {
abstract class LoginCommandModule {
...

@BindsOptionalOf
Account optionalAccount();
abstract Account optionalAccount();
}
```

Expand Down
Loading