Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vi: What is Rust? #2003

Merged
merged 2 commits into from
May 3, 2024
Merged

vi: What is Rust? #2003

merged 2 commits into from
May 3, 2024

Conversation

ndminhvn
Copy link
Contributor

Here is the translation of What is Rust?

Copy link
Collaborator

@qu-ngx qu-ngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! I also marked a better alternation but it's not needed since we already have the original English version next to the translated terminologies.

po/vi.po Outdated Show resolved Hide resolved
po/vi.po Show resolved Hide resolved
@mgeisler
Copy link
Collaborator

mgeisler commented May 3, 2024

It looks good!

Thanks for reviewing it, @qu-ngx! Can you mark the PR as reviewed using the GitHub interface so we can merge it? If you're not already a reviewer in the repository, @henrif75 should be able to help you out!

@qu-ngx
Copy link
Collaborator

qu-ngx commented May 3, 2024

@mgeisler I am currently not a reviewer in the repo. Can you tell @henrif75 to add me as one?

@daivinhtran daivinhtran merged commit 4125e23 into google:main May 3, 2024
34 checks passed
@henrif75
Copy link
Collaborator

henrif75 commented May 3, 2024

@mgeisler I am currently not a reviewer in the repo. Can you tell @henrif75 to add me as one?

Hi @qu-ngx I created #2051. You should also have gotten an email inviting you to be a writer in the repository, you'll need to accept it before you're able to approve PRs.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants