Configurable redis-instance name #3841
Conversation
|
Can I get a This is ready for review |
| @@ -98,7 +98,7 @@ else | |||
|
|
|||
| export CLOUD_SDK_REPO="cloud-sdk" | |||
| export APT_FILE=/etc/apt/sources.list.d/google-cloud-sdk.list | |||
| export APT_LINE="deb http://packages.cloud.google.com/apt $CLOUD_SDK_REPO main" | |||
| export APT_LINE="deb https://packages.cloud.google.com/apt $CLOUD_SDK_REPO main" | |||
There was a problem hiding this comment.
trying to install cloud-sdk now fails on ubuntu20 unless using https.
https usage is also how they do it in https://cloud.google.com/sdk/docs/install
|
@jonathanmetzman bumping this |
| @@ -98,7 +98,7 @@ else | |||
|
|
|||
| export CLOUD_SDK_REPO="cloud-sdk" | |||
| export APT_FILE=/etc/apt/sources.list.d/google-cloud-sdk.list | |||
| export APT_LINE="deb http://packages.cloud.google.com/apt $CLOUD_SDK_REPO main" | |||
| export APT_LINE="deb https://packages.cloud.google.com/apt $CLOUD_SDK_REPO main" | |||
There was a problem hiding this comment.
Have you tested this? I feel like Apt uses pgp keys instead of SSL to verify packages.
There was a problem hiding this comment.
Nevermind, you've answered this question already somehow :-)
There was a problem hiding this comment.
Tested on an ubuntu20.04 Docker image of mine. About a month or so ago http worked but now it fails whereas https works
There was a problem hiding this comment.
For version 2.6.0 http seems to still work for google-cloud-sdk (for install_deps.bash). Trying to deploy from master was where I needed https
There was a problem hiding this comment.
I want to think about how we can do this in a way that adds less complexity, since this isn't a change that's useful to us. I think maybe through a config file.
jonathanmetzman
force-pushed
the
master
branch
2 times, most recently
from
e7e91a0
to
22e1108
Compare
Summary
Currently the redis instance needs to be called
redis-instance. Allow users to customize this and default toredis-instanceif not provided.Adds a fix to the cloud_sdk install which appears to be broken on Ubuntu20.04 (http -> https)
Testing
I only tested the prod deploy workflow and not staging, but it should be equivalent.
I didn't touch
_deploy_k8swhich calls_get_redis_ip, but this should default to the defaultredis-instancecase