Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support viewForRow in grey_pickerColumnSetToValue matcher #1810

Open
wants to merge 1 commit into
base: earlgrey2
Choose a base branch
from

Conversation

MontakOleg
Copy link

Matcher grey_pickerColumnSetToValue works fine for UIPicker with delegate that implements

  • pickerView:titleForRow:forComponent OR
  • pickerView:attributedTitleForRow:forComponent

but currently does not work for pickerView:viewForRow:forComponent:reusingView:

I believe it should work with viewForRow, because GREYPickerAction works fine with it and there even test that checks it – PickerViewInteractionTest.testViewForRowDefined.

Unfortunately, I think that this test is broken: corresponding PickerViewController implements both delegate methods – pickerView:titleForRow:forComponent AND pickerView:viewForRow:forComponent:reusingView:, that why test pass.

So, I added support for viewForRow in grey_pickerColumnSetToValue matcher, its just copy-paste from GREYPickerAction and updated test code.

@google-cla
Copy link

google-cla bot commented Aug 13, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@tirodkar
Copy link
Collaborator

Can you sign the CLA please? @AlbertWang0116 is to look into merging this in. Albert - feel free to patch and test this internally and then close this contribution once the CLA check is passed.

@MontakOleg
Copy link
Author

Sure, SLA should be already signed (as mentioned in Checks section)

@MontakOleg
Copy link
Author

@AlbertWang0116, did you have a chance to look at this?

@MontakOleg
Copy link
Author

@tirodkar, @AlbertWang0116 hi guys, any news here?

@tirodkar
Copy link
Collaborator

tirodkar commented Apr 5, 2023

Will patch and let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants