Modify JIT of transport model to be defined on hash of TransportModel so that subsequent simulations hit cache. #903
+6
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_739945207
branch
7 times, most recently
from
8c3d118 to
33d08c9
Compare
… so that subsequent simulations hit cache. Also: - remove jitted_transport_model from step function as this will be cache missed in subsequent simulations. - remove inner JIT from qlknn_transport_model as this is now covered by the JIT on __call__. Otherwise this misses a lookup as the function is defined on an object by id. PiperOrigin-RevId: 741482176
copybara-service
bot
force-pushed
the
test_739945207
branch
from
33d08c9 to
f7e295b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify JIT of transport model to be defined on hash of TransportModel so that subsequent simulations hit cache.
Also:
Otherwise this misses a lookup as the function is defined on an object by id.