Add docs on interfacing with surrogates#804
Conversation
jcitrin
left a comment
There was a problem hiding this comment.
Thanks for this! Really awesome and appreciated that you are writing documentation.
Made a few comments. @hamelphi , @sbodenstein , @ernoc could you also take a look at this?
|
When fusion_transport_surrogates matures more it will hopefully help abstract away some of this and we can supplement/modify these docs with examples using that library |
|
Nice! LGTM. Thanks for the contribution Theo. |
|
Thanks for the comments, sorry for the delay in responding! |
|
Following some of the suggestions made by @sbodenstein, I've added a bit on saving/loading models in HLO format, which is the one backed by OpenXLA. |
|
I've just made the changes @sbodenstein requested. However, after rebasing onto main I've discovered that the relevant docs page has changed to no longer contain information on how to integrate new models into TORAX - I imagine because a specific API/framework for doing so is to be developed, and you guys are currently crunching for v1.0.0. Is this PR dead, then, or will this info be useful somewhere sometime in the future? |
|
Hi Theo. I think it's still useful to include and if done right now can be part of the v1.0.0 docs (release planned imminently). Best would be to not include all of |
|
Super, can do. Give me a couple of mins |
|
Done! |
Includes:
torch_xla2jaxonnxruntimePotentially closes #538