Add settings cancel API #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 8441a37): https://golioth-firmware-sdk-doxygen-dev--pr481-szczys-add-set-nhf2tzkh.web.app (expires Wed, 29 May 2024 03:32:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
szczys
force-pushed
the
szczys/add_rpc_cancel
branch
3 times, most recently
from
7adb16d
to
56a80b0
Compare
sam-golioth
reviewed
May 20, 2024
src/settings.c
Outdated
| @@ -463,6 +463,21 @@ struct golioth_settings *golioth_settings_init(struct golioth_client *client) | |||
| return gsettings; | |||
| } | |||
|
|
|||
| enum golioth_status golioth_settings_deinit(struct golioth_client *client, | |||
There was a problem hiding this comment.
Same comment as the RPC PR: We can extract client from settings so this function only needs to take one argument.
tests/hil/tests/settings/test.c
Outdated
|
|
||
| golioth_sys_sem_take(connected_sem, GOLIOTH_SYS_WAIT_FOREVER); | ||
|
|
||
| perform_settings_registration(client); |
There was a problem hiding this comment.
If we change this function to return struct golioth_settings * then we can keep settings as a local stack variable instead of moving it to a global.
szczys
force-pushed
the
szczys/add_rpc_cancel
branch
3 times, most recently
from
89d18f7
to
6fa46b1
Compare
szczys
force-pushed
the
szczys/add_settings_cancel
branch
from
b8ec242
to
1bc20f4
Compare
sam-golioth
approved these changes
May 21, 2024
szczys
force-pushed
the
szczys/add_settings_cancel
branch
2 times, most recently
from
a4a4e7a
to
619c0ee
Compare
Add golioth_settings_deinit() function that cancels Settings observations and frees the Settings context struct (used to store the registered Settings paths). Signed-off-by: Mike Szczys <[email protected]>
Signed-off-by: Mike Szczys <[email protected]>
szczys
force-pushed
the
szczys/add_settings_cancel
branch
from
619c0ee
to
8441a37
Compare
Code Coverage
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add API to cancel settings observations and free the settings service context.
Resolves https://github.com/golioth/firmware-issue-tracker/issues/521