Add golioth_rpc_deinit() API #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szczys
force-pushed
the
szczys/add_rpc_cancel
branch
from
2e8039d
to
0bcfd12
Compare
|
Visit the preview URL for this PR (updated for commit 6fa46b1): https://golioth-firmware-sdk-doxygen-dev--pr478-szczys-add-rpc-z2qrnhn3.web.app (expires Tue, 28 May 2024 16:12:18 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
Code Coverage
|
szczys
force-pushed
the
szczys/add_rpc_cancel
branch
3 times, most recently
from
83c528d
to
4336422
Compare
szczys
commented
May 3, 2024
szczys
force-pushed
the
szczys/cancel_observations
branch
from
161664d
to
26ecaa6
Compare
szczys
force-pushed
the
szczys/add_rpc_cancel
branch
3 times, most recently
from
7adb16d
to
56a80b0
Compare
szczys
force-pushed
the
szczys/cancel_observations
branch
2 times, most recently
from
5752223
to
19334fc
Compare
sam-golioth
reviewed
May 20, 2024
| @@ -23,5 +23,5 @@ DECLARE_FAKE_VALUE_FUNC(enum golioth_status, | |||
| bool, | |||
| int32_t); | |||
| DECLARE_FAKE_VOID_FUNC(golioth_coap_client_cancel_observations_by_prefix, | |||
| struct golioth_client *, | |||
| const char *); | |||
| struct golioth_client *, | |||
There was a problem hiding this comment.
NIT: would be cleaner to fix this in the previous commit.
src/rpc.c
Outdated
| @@ -234,6 +234,20 @@ struct golioth_rpc *golioth_rpc_init(struct golioth_client *client) | |||
| return grpc; | |||
| } | |||
|
|
|||
| enum golioth_status golioth_rpc_deinit(struct golioth_client *client, struct golioth_rpc *grpc) | |||
There was a problem hiding this comment.
We can extract client from grpc so this function only needs one argument.
szczys
force-pushed
the
szczys/cancel_observations
branch
from
19334fc
to
724cfae
Compare
szczys
force-pushed
the
szczys/add_rpc_cancel
branch
2 times, most recently
from
65aae50
to
89d18f7
Compare
mniestroj
approved these changes
May 21, 2024
sam-golioth
approved these changes
May 21, 2024
The prefix indicates the type of observation and will be be used by the service APIs to cancel by service. Signed-off-by: Mike Szczys <[email protected]>
The prefix indicates the type of observation and will be be used by the service APIs to cancel by service. Signed-off-by: Mike Szczys <[email protected]>
Implement golioth_coap_client_cancel_observations_by_prefix() to wrap the functions provided by the ports. Signed-off-by: Mike Szczys <[email protected]>
Add golioth_rpc_deinit() function that cancels RPC observations and frees the RPC context struct (used to store the registered RPC paths/methods). Signed-off-by: Mike Szczys <[email protected]>
Update the test to use the RPC deinit API instead of the internal cancel observations function. Signed-off-by: Mike Szczys <[email protected]>
szczys
force-pushed
the
szczys/add_rpc_cancel
branch
from
89d18f7
to
6fa46b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves https://github.com/golioth/firmware-issue-tracker/issues/520