Fix _covered_call deep ITM delta default and remove OTM% selection path#181
Closed
Copilot wants to merge 1 commit intoclaude/per-leg-delta-targetingfrom
Closed
Fix _covered_call deep ITM delta default and remove OTM% selection path#181Copilot wants to merge 1 commit intoclaude/per-leg-delta-targetingfrom
_covered_call deep ITM delta default and remove OTM% selection path#181Copilot wants to merge 1 commit intoclaude/per-leg-delta-targetingfrom
Conversation
4 tasks
Copilot
AI
changed the title
[WIP] WIP Address feedback on covered call function implementation
Fix Feb 25, 2026
_covered_call deep ITM delta default and remove OTM% selection path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_covered_calldefaultedleg1_deltato ATM (~0.50), contradicting the docstring describing it as a synthetic long stock position. Multi-leg helpers (_spread,_butterfly) also used symmetric deltas, causing legs to collapse onto the same strikes. Separately, the OTM% and delta-targeting code paths had significant duplication acrosscore.pyandevaluation.py.Changes
Delta defaults corrected (
_helpers.py)_covered_call:leg1_delta→DEEP_ITM(target=0.80, range[0.60, 0.95]) to properly simulate synthetic long stock_spread:leg1→ ATM (0.50),leg2→ OTM (0.10) so legs select distinct strikes_butterfly:leg1→ ITM wing (0.40),leg2→ ATM (0.50),leg3→ OTM wing (0.10)_DEFAULT_DEEP_ITM_DELTA,_DEFAULT_ITM_WING_DELTA,_DEFAULT_OTM_WING_DELTAOTM% path removed (
core.py,evaluation.py,filters.py,types.py)max_otm_pct,otm_pct_interval,delta_min,delta_maxparams droppeddelta_range(wasotm_pct_range)deltacolumn is now required in input dataDuplication consolidated
_match_entries_exits()extracted as shared helper inevaluation.py_merge_legs()extracted incore.py, shared between_strategy_engine()and_process_strategy_delta_targeted()Docstrings updated (
covered_call,protective_put) to reflect delta-based defaults and note the synthetic-only limitation💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.