Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seek not updating currentTime #1572

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

FlyersWeb
Copy link

Issue/Feature

Using html5 the seek function do not update the audio currentTime consistently, this cause the seek() to sometimes return incorrect timestamp value.

Related Issues

I've not created issue because I cannot release code associated to the issue.

Solution

I've noticed that the currentTime update depends on the presence of duration, this is why sometimes the currentTime is not updated.

Reproduction/Testing

Reproduction is not easy but you could try to creat an animationFrame using html5 audio to get seek value and update it regularly and see that if audio has no duration set it would not update.

Breaking Changes

N/A

Release

I couldn't create a release because npm run build failed on my machine because of the sed part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant