WIP: auto pronounce from next dictionary #972
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This message box can be annoying.
TODO: remove all mentions of gdAudioLinks.first. Fixes goldendict#970.
This can improve performance in case of many duplicate links.
Use gdAudioLinks.all in ArticleView::hasSound() instead.
|
Implemented the TODOs in the last 3 commits. |
…o wip-auto-pronounce-from-next-dictionary
Before this commit there were no clear criteria for ArticleView::openLink() and ArticleView::resourceDownloadFinished() return values. Now there are documented and implemented criteria, which will hopefully be useful in future uses of these functions. Right now the dependent code cares about return values only when an audio resource is requested. ArticleView::openLink() should return false if the audio resource does not exist or can not be downloaded; true otherwise: in case of success, asynchronous downloading (to prevent playing more than one pronunciation) or an audio player failure (to prevent a long sequence of errors in case of incorrect audio player configuration or a bug).
…o wip-auto-pronounce-from-next-dictionary
…o wip-auto-pronounce-from-next-dictionary
…o wip-auto-pronounce-from-next-dictionary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes seem to fix #970 for me.
My DSL dictionary's links still play the LSA dictionary's pronunciations.
I plan to address several TODOs:
I don't know if this code handles XDXF resource search type correctly because I don't have any XDXF dictionaries to test.
@Abs62, what do you think about these changes? Do you have any suggestions?