Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pt-PT language #1693

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add pt-PT language #1693

wants to merge 2 commits into from

Conversation

Leinad4Mind
Copy link

No description provided.

@vedgy
Copy link
Member

vedgy commented Mar 24, 2024

Please insert the line locale/pt_PT.ts \ just under the line locale/pt_BR.ts \ in goldendict.pro.

I just did that and tried to build GoldenDict. The result is an error:

lrelease error: Parse error at ../locale/pt_PT.ts:278:27: Expected ''' or '"', but got '[a-zA-Z]'.
make: *** [Makefile:1565: locale/pt_PT.qm] Error 1

Can you build GoldenDict locally to catch and fix this and possible other such errors?

@Leinad4Mind
Copy link
Author

Done, added the locale. Should be all good now.

@vedgy
Copy link
Member

vedgy commented Mar 24, 2024

The issue on the line 278, column 27 in the file pt_PT.ts is not fixed. You'll see this error (and possibly others after fixing it) if you run lupdate, and build GoldenDict locally (or run lrelease manually).

@Leinad4Mind
Copy link
Author

Sorry. I am not able to run this locally.

@vedgy
Copy link
Member

vedgy commented Mar 28, 2024

Do you not have Qt (lupdate and lrelease) installed?

You can start by fixing the line 278 and the same issue on the line 283. In the file pt_BR.ts the lines are equal to:

        <translation type="unfinished"></translation>

And in pt_PT.ts:

        <translation type=Frase não encontrada></translation>
        <translation type=%1 de %2 encontrados></translation>

Since the translation is now finished, the type attribute should be removed entirely and the translations always go between > and < (in the translation tag). Did you edit the .ts file by hand? I just searched for the type=[^"] regex in the file pt_PT.ts and found nothing else like that. So there is a good chance fixing these two lines would fix the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants