Prepare Lojban .ts file for Qt5's lupdate #1651
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit eliminates the following warning in the output of command `lupdate goldendict.pro`: File /path/to/goldendict/locale/jb_JB.ts won't be updated: it contains translation but the target language is not recognized The issue was introduced in Qt 5.13 and cherry-picked into Qt 5.12.4: https://codereview.qt-project.org/c/qt/qttools/+/255003 The .ts file is not updated, because the Lojban language is absent from Qt's numerusTable in qttools/src/linguist/shared/numerus.cpp. Work the issue around by setting the language attribute of the TS element to a suitable supported language code "ja" (Japanese). Words in Lojban do not actually have a separate plural form, like in Japanese. So this way plural translations should be handled correctly. Closes goldendict#1642
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit eliminates the following warning in the output of command
lupdate goldendict.pro:The issue was introduced in Qt 5.13 and cherry-picked into Qt 5.12.4: https://codereview.qt-project.org/c/qt/qttools/+/255003
The .ts file is not updated, because the Lojban language is absent from Qt's numerusTable in qttools/src/linguist/shared/numerus.cpp.
Work the issue around by setting the language attribute of the TS element to a suitable supported language code "ja" (Japanese). Words in Lojban do not actually have a separate plural form, like in Japanese. So this way plural translations should be handled correctly.
Closes #1642