Let Qt determine the paths #1611
Conversation
Hardcoding the path (i.e. a generic path + a hardcoded dir name) is redundant and prone to triggering errors. And it creates error inside a Flatpak.
| @@ -2396,11 +2400,7 @@ QString getCacheDir() throw() | |||
| { | |||
| return isPortableVersion() ? portableHomeDirPath() + "/cache" | |||
| #if QT_VERSION >= QT_VERSION_CHECK( 5, 0, 0 ) | |||
| #ifdef HAVE_X11 | |||
| : QStandardPaths::writableLocation( QStandardPaths::GenericCacheLocation ) + "/goldendict"; | |||
There was a problem hiding this comment.
Does the directory name become GoldenDict (camel case) with this change?
There was a problem hiding this comment.
They become all lowercase due to the setting of the application, because you define the application name so:
Line 2 in 1dfc44a
Do you want me to change the application name to Carmel Case, or add a backward compatible handling?
There was a problem hiding this comment.
you define the application name
No, the application name is defined here:
Line 332 in 1dfc44a
The TARGET is the executable name.
There was a problem hiding this comment.
There was a consensus in comments to #1411 to use the lower-case directory name. Though I had slightly preferred the Qt-default camel-case myself. Because of backward compatibility concerns, changing to camel-case now should be done only in case of very strong consensus, which is highly unlikely. Find an approach that fixes the Flatpak issue without affecting the application behavior.
|
@proletarius101, what is the exact issue for Flatpak that this PR aims to solve? Are |
Hardcoding the path (i.e. a generic path + a hardcoded dir name) is redundant and prone to triggering errors. And it creates error inside a Flatpak.