Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore dictionary toolbar handle in Modern style #1117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vedgy
Copy link
Member

@vedgy vedgy commented Feb 4, 2019

Moving dictionaryBar with invisible handle is possible but difficult and
practically undiscoverable.
I can think of two reasons a user might want to move this toolbar:

  • increase the width of translate line to the user's liking;
  • move dictionary bar to a vertical position like in scan popup.

If a user applies her own tweaks on top of standard Modern style in
user-defined qt-style.css, it is more obvious how to hide this handle
than how to restore it when it is already hidden by the built-in style.

Moving dictionaryBar with invisible handle is possible but difficult and
practically undiscoverable.
I can think of two reasons a user might want to move this toolbar:
  * increase the width of translate line to the user's liking;
  * move dictionary bar to a vertical position like in scan popup.

If a user applies her own tweaks on top of standard Modern style in
user-defined qt-style.css, it is more obvious how to hide this handle
than how to restore it when it is already hidden by the built-in style.
@vedgy
Copy link
Member Author

vedgy commented Feb 4, 2019

I don't expect this pull request to be merged into master anytime soon due to this comment. It is here to find a workaround, for discussion and for possible distant future merge.

I'd like to make the handle look like after applying this pull request without modifying qt-style-st-modern.css. After reading this answer I tried to do this by adding the following code into my <Goldendict user directory>/qt-style.css:

#dictionaryBar::handle {
  all: initial;
  * {
    all: unset;
  }
}

Unfortunately this solution doesn't work. Any other ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant