Don't defer the session save

golangkorea · Mar 30, 2019 · e0291d8 · e0291d8
1 parent c4ec943
commit e0291d8
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/handler/auth.go b/handler/auth.go
@@ -25,11 +25,11 @@ func GoogleAuthCallback(w http.ResponseWriter, r *http.Request) {
 		http.Error(w, err.Error(), http.StatusInternalServerError)
 		return
 	}
-	defer session.Save(r, w)
 
 	// Validate state value
 	state := session.Values["state"]
 	delete(session.Values, "state")
+	session.Save(r, w)
 	if state != r.FormValue("state") {
 		http.Error(w, "invalid session state", http.StatusUnauthorized)
 		return
@@ -68,6 +68,7 @@ func GoogleAuthCallback(w http.ResponseWriter, r *http.Request) {
 		MaxAge: 86400,
 	}
 	session.Values["user"] = user
+	session.Save(r, w)
 
 	// Redirect to profile page
 	http.Redirect(w, r, "/profile", http.StatusFound)