Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add default exclusion names to the JSONSchema #5338

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

ccoVeille
Copy link
Contributor

@ccoVeille ccoVeille commented Jan 20, 2025

I would like to suggest this simple addition

It could avoid loosing time as I did.
I was using EXC014 (instead of EXC0014) and I had to debug everything to figure our the problem was between keyboard and chair.

I validated it worked with the following command:

go run cmd/golangci-lint/main.go config verify --schema jsonschema/golangci.next.jsonschema.json --config /path/golangci.yml

I also checked at the code and it should be safe

https://github.com/golangci/golangci-lint/blob/v1.63.4/pkg/config/issues.go#L233-L247

@ldez ldez changed the title feat: validate default exclusions via the schema docs: validate default exclusions via the schema Jan 20, 2025
@ldez ldez changed the title docs: validate default exclusions via the schema docs: add default exclusion names to the JSONSchema Jan 20, 2025
@ldez
Copy link
Member

ldez commented Jan 20, 2025

There is no need for regexp, the default exclusion names are known.

Also, those names will be removed: #5298

@ldez ldez added this to the next milestone Jan 20, 2025
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit e247601 into golangci:master Jan 20, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants