Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

govet: add directive and slog passes #4028

Merged
merged 3 commits into from
Aug 19, 2023
Merged

govet: add directive and slog passes #4028

merged 3 commits into from
Aug 19, 2023

Conversation

johejo
Copy link
Contributor

@johejo johejo commented Aug 19, 2023

@ldez ldez added the linter: update Update the linter implementation inside golangci-lint label Aug 19, 2023
@ldez ldez self-requested a review August 19, 2023 08:45
@ldez ldez changed the title govet: add directive and slog govet: add directive and slog passes Aug 19, 2023
@ldez ldez added the enhancement New feature or improvement label Aug 19, 2023
ldez
ldez approved these changes Aug 19, 2023
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit a5eaf9f into golangci:master Aug 19, 2023
10 checks passed
@marians marians mentioned this pull request Oct 31, 2023
Closed
@ldez ldez added this to the v1.54 milestone Mar 6, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
enhancement New feature or improvement linter: update Update the linter implementation inside golangci-lint
Projects
None yet
Milestone
v1.54
Development

Successfully merging this pull request may close these issues.
2 participants
@johejo @ldez