Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev: CI cleanups #4008

Merged
merged 2 commits into from
Aug 12, 2023
Merged

dev: CI cleanups #4008

merged 2 commits into from
Aug 12, 2023

Conversation

scop
Copy link
Contributor

@scop scop commented Aug 11, 2023

Some CI config cleanups, noticed while working on something else. GITHUB_TOKEN env scoping not fully tested, but I believe it could work like this.

@ldez ldez added the area: ci PR that update CI label Aug 11, 2023
@ldez ldez self-requested a review August 11, 2023 21:55
@ldez ldez changed the title CI cleanups dev: CI cleanups Aug 11, 2023
ldez
ldez requested changes Aug 11, 2023
View reviewed changes
.github/workflows/tag.yml Outdated Show resolved Hide resolved
.github/workflows/tag.yml Outdated Show resolved Hide resolved
ldez
ldez requested changes Aug 11, 2023
View reviewed changes
.github/workflows/pr.yml Show resolved Hide resolved
@ldez ldez added the feedback required Requires additional feedback label Aug 11, 2023
ldez
ldez approved these changes Aug 12, 2023
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: It's better to address review as a commit, it's better to follow changes.

@ldez ldez removed the feedback required Requires additional feedback label Aug 12, 2023
@ldez ldez merged commit 6efb009 into golangci:master Aug 12, 2023
14 checks passed
@scop scop deleted the ci/cleanups branch August 14, 2023 20:48
@ldez ldez added this to the v1.54 milestone Mar 6, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area: ci PR that update CI
Projects
None yet
Milestone
v1.54
Development

Successfully merging this pull request may close these issues.
2 participants
@scop @ldez