-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: change defer linter to nakedefer
- Loading branch information
Showing
10 changed files
with
157 additions
and
87 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| package golinters | ||
|
|
||
| import ( | ||
| "github.com/GaijinEntertainment/go-nakedefer/pkg/analyzer" | ||
| "golang.org/x/tools/go/analysis" | ||
|
|
||
| "github.com/golangci/golangci-lint/pkg/config" | ||
| "github.com/golangci/golangci-lint/pkg/golinters/goanalysis" | ||
| ) | ||
|
|
||
| func NewNakedefer(settings *config.NakedeferSettings) *goanalysis.Linter { | ||
| var exclude []string | ||
|
|
||
| if settings != nil { | ||
| exclude = settings.Exclude | ||
| } | ||
|
|
||
| a, err := analyzer.NewAnalyzer(exclude) | ||
| if err != nil { | ||
| linterLogger.Fatalf("nakedefer configuration: %v", err) | ||
| } | ||
|
|
||
| return goanalysis.NewLinter( | ||
| a.Name, | ||
| a.Doc, | ||
| []*analysis.Analyzer{a}, | ||
| nil, | ||
| ).WithLoadMode(goanalysis.LoadModeTypesInfo) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| linters-settings: | ||
| nakedefer: | ||
| exclude: ignoreFunc,os\.(Create|WriteFile|Chmod),fmt\.Print.*,io\.Close |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,91 @@ | ||
| // golangcitest:args -Enakedefer | ||
| // golangcitest:config_path: testdata/configs/nakedefer.yml | ||
| package testdata | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "errors" | ||
| "fmt" | ||
| "io" | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "os" | ||
| ) | ||
|
|
||
| func funcNotReturnAnyType() { | ||
| } | ||
|
|
||
| func funcReturnErr() error { | ||
| return errors.New("some error") | ||
| } | ||
|
|
||
| func funcReturnFuncAndErr() (func(), error) { | ||
| return func() { | ||
| }, nil | ||
| } | ||
|
|
||
| func ignoreFunc() error { | ||
| return errors.New("some error") | ||
| } | ||
|
|
||
| func testCaseValid1() { | ||
| defer funcNotReturnAnyType() // ignore | ||
|
|
||
| defer func() { //ignore | ||
| funcNotReturnAnyType() | ||
| }() | ||
|
|
||
| defer func() { //ignore | ||
| _ = funcReturnErr() | ||
| }() | ||
| } | ||
|
|
||
| func testCaseInvalid1() { | ||
| defer funcReturnErr() // want "deferred call should not return anything" | ||
|
|
||
| defer funcReturnFuncAndErr() // want "deferred call should not return anything" | ||
|
|
||
| defer func() error { // want "deferred call should not return anything" | ||
| return nil | ||
| }() | ||
|
|
||
| defer func() func() { // want "deferred call should not return anything" | ||
| return func() {} | ||
| }() | ||
| } | ||
|
|
||
| func testCase1() { | ||
| defer fmt.Errorf("some text") // want "deferred call should not return anything" | ||
|
|
||
| r := new(bytes.Buffer) | ||
| defer io.LimitReader(r, 1) // want "deferred call should not return anything" | ||
|
|
||
| srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { | ||
| w.WriteHeader(http.StatusOK) | ||
| _, _ = w.Write([]byte("DONE")) | ||
| })) | ||
| defer srv.Close() // ignore | ||
| defer srv.CloseClientConnections() // ignore | ||
| defer srv.Certificate() // want "deferred call should not return anything" | ||
| } | ||
|
|
||
| func testCaseExclude1() { | ||
| // exclude ignoreFunc | ||
| defer ignoreFunc() // ignore | ||
| } | ||
|
|
||
| func testCaseExclude2() { | ||
| // exclude os\.(Create|WriteFile|Chmod) | ||
| defer os.Create("file_test1") // ignore | ||
| defer os.WriteFile("file_test2", []byte("data"), os.ModeAppend) // ignore | ||
| defer os.Chmod("file_test3", os.ModeAppend) // ignore | ||
| defer os.FindProcess(100500) // want "deferred call should not return anything" | ||
| } | ||
|
|
||
| func testCaseExclude3() { | ||
| // exclude fmt\.Print.* | ||
| defer fmt.Println("e1") // ignore | ||
| defer fmt.Print("e1") // ignore | ||
| defer fmt.Printf("e1") // ignore | ||
| defer fmt.Sprintf("some text") // want "deferred call should not return anything" | ||
| } |