CellUnionFromDifference: Optimize #252
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benguild
commented
Dec 25, 2025
|
|
||
| // cellUnionDifferenceInternal adds (xid - y) to the CellUnion. It subdivides | ||
| // xid when there is partial overlap, narrowing y before recursing. | ||
| func (cu *CellUnion) cellUnionDifferenceInternal(xid CellID, y CellUnion) { |
Contributor
Author
There was a problem hiding this comment.
I moved this prior to the exported method to match C++ and have better proximity.
benguild
commented
Dec 25, 2025
| var cu CellUnion | ||
| for _, xid := range x { | ||
| cu.cellUnionDifferenceInternal(xid, &y) | ||
| cu.cellUnionDifferenceInternal(xid, y) |
Contributor
Author
There was a problem hiding this comment.
It seemed OK to pass by value
benguild
commented
Dec 25, 2025
| return | ||
| } | ||
|
|
||
| y = y[lo:hi] |
Contributor
Author
There was a problem hiding this comment.
By reducing the size of "y" we're narrowing the search in the call to "ContainsCellID" and in recursive calls.
Collaborator
|
Are there benchmarks for this? |
jmr
changed the title
CellUnionFromDifference to resolve TODO
Collaborator
|
+1 to the comment above. Could you please implement a benchmark similar to BenchmarkCellUnionFromRange, then test the difference under your change? |
Contributor
Author
|
Thanks all, I've seen the comments and when I'm able to clear the backlog on my side I'll take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title explains, I'll include comment(s) in the diff. I think this is correct (?) and tried to expand the tests as well, but please let me know if you see any issues.