Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livereload: Update livereload.js to v4.0.2 #12451

Closed

Conversation

jmooring
Copy link
Member

@jmooring jmooring commented May 1, 2024

We no longer need a patched version because livereload/livereload-js#84 was merged on 28 Dec 2019.

Closes #6290

We no longer need a patched version because livereload/livereload-js#84
was merged on 28 Dec 2019.

Closes gohugoio#6290
bep added a commit to bep/hugo that referenced this pull request May 2, 2024
This script has very infrequent updates, but just copy pasting the minified source creates some potential trust issues.

This JS will now be pulled from a Git version and both the unminified and minified version gets written to disk.

This way it should be easier to reason about changes in the future.

To upgrade, change the commit hash and run `mage generate`.

Closes gohugoio#12451
Closes gohugoio#6290
@jmooring jmooring closed this May 2, 2024
@jmooring jmooring deleted the livereload-update-to-4.0.2-6290 branch May 2, 2024 10:23
bep added a commit to bep/hugo that referenced this pull request May 2, 2024
This script has very infrequent updates, but just copy pasting the minified source creates some potential trust issues.

This JS will now be pulled from a Git version and both the unminified and minified version gets written to disk.

This way it should be easier to reason about changes in the future.

To upgrade, change the commit hash and run `mage generate`.

Closes gohugoio#12451
Closes gohugoio#6290
bep added a commit that referenced this pull request May 10, 2024
This script has very infrequent updates, but just copy pasting the minified source creates some potential trust issues.

This JS will now be pulled from a Git version and both the unminified and minified version gets written to disk.

This way it should be easier to reason about changes in the future.

To upgrade, change the commit hash and run `mage generate`.

Closes #12451
Closes #6290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Livereload.js has ES6 code after 2fc0abd
1 participant