Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add FSEvents-based watcher on macOS #10098

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add FSEvents-based watcher on macOS #10098

wants to merge 2 commits into from

Commits on Jan 1, 2023

  1. add FSEvents-based watcher on macOS 

    On macOS, `fsnotify` uses `kqueue` internally.
This causes some long-lasting issues (gohugoio#8594, gohugoio#6109)
though we have the workaround for them.

This PR tries to resolve these issues by using `FSEvents` instead of `kqueue`.

ref https://discourse.gohugo.io/t/fsevents-for-watching-on-macos/39053/4

Use FSEventsWatcher as default on darwin

* eventwatcher_darwin.go
  * NewEventWather returns fsEventWatehr

* eventwatcher_other.go
  * NewEventWather returns fsNotifyWatcher
    @satotake
    satotake committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    7dcfd3e View commit details
    Browse the repository at this point in the history

  2. CREATE event check can be skipped

    @satotake
    satotake committed Jan 1, 2023
    Configuration menu
    Copy the full SHA
    0584c2f View commit details
    Browse the repository at this point in the history