Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cmd/gf): table and field names converted to its lower case before CamelCase converting in command gen dao #3801

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

gqcn
Copy link
Member

@gqcn gqcn commented Sep 24, 2024

fixed #3749

@gqcn gqcn requested a review from oldme-git September 24, 2024 03:47
Copy link

sonarcloud bot commented Sep 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
10.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@gqcn gqcn changed the title fix(cmd/gf): table and field name converting to its lower case in generated dao/do/entity go files fix(cmd/gf): table and field names converted to its lower case before CamelCase converting in command gen dao Sep 24, 2024
@gqcn gqcn merged commit ab2c3b0 into master Sep 25, 2024
56 checks passed
@gqcn gqcn deleted the fix/3749 branch September 25, 2024 02:59
houseme added a commit that referenced this pull request Sep 28, 2024
…ris-config

* 'master' of github.com:gogf/gf: (23 commits)
  build(go.mod): upgrade minimum required go version from 1.18 to 1.20 (#3688)
  refactor(net/ghttp): enhance `ghttp.StartPProfServer` (#3555)
  refactor(encoding/gjson): change data parameter from type any to []byte (#3542)
  refactor(net/gudp): improve implements (#3491)
  fix(os/gcache): memory leak for LRU when adding operations more faster than deleting (#3823)
  fix(os/gcmd): argument index calculating error in multilevel command (#3807)
  fix(database/gdb): invalid order by statement generated when multiple order inputs (#3803)
  fix(cmd/gf): creating logic.go empty folder when there is no correct logic service (#3815)
  test(drivers/mysql): loose unit testing for transaction (#3819)
  fix(net/ghttp&gclient,contrib/rpc/grpcx): remove request and response contents in opentelemetry tracing attributes (#3810)
  feat: new version v2.7.4 (#3809)
  fix(util/gconv): unstable converting when there is an external attribute with the same name as the internal structure (#3799)
  feat(database/gdb): add year field type support for ORM operations (#3805)
  fix(cmd/gf): table and field names converted to its lower case before CamelCase converting in command `gen dao` (#3801)
  fix(net/gclient): panic when containing `@file:` parameter value in json post request (#3775)
  feat(contrib/registry/etcd/): add `DialTimeout` and `AutoSyncInterval` option (#3698)
  fix(database/gdb): support OrderRandom feature in different databases (#3794)
  fix(net/goai): change default value of RequestBody.Required from true to false, add required tag support for RequestBody (#3796)
  fix(util/gvalid): retrive empty slice parameter in custom validation rule function failed (#3795)
  fix(util/gconv): cached field indexes append issue caused incorrect field converting (#3790)
  ...

# Conflicts:
#	.github/workflows/ci-main.sh
#	.github/workflows/golangci-lint.yml
#	contrib/metric/otelmetric/go.mod
@jarry8359
Copy link

\cmd\gf\internal\cmd\gendao\gendao_structure.go
Line 74:jsonTag = gstr.CaseConvert(strings.ToLower(field.Name), gstr.CaseTypeMatch(in.JsonCase))
fix entity json to its lower case before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The field names generated by "gf gen dao" have changed. v2.7.2
3 participants