Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: UnmarshalJSON of dst not called when gjson.Scan #3769 #3770

Closed
wants to merge 2 commits into from
Closed

fix: UnmarshalJSON of dst not called when gjson.Scan #3769 #3770

wants to merge 2 commits into from

Conversation

wlynxg
Copy link
Contributor

@wlynxg wlynxg commented Sep 12, 2024

Fix: #3769

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@wlynxg
Copy link
Contributor Author

wlynxg commented Sep 12, 2024

This PR will affect many of the original unit tests.💔

@gqcn
Copy link
Member

gqcn commented Sep 12, 2024

@wlynxg Hello, thanks for you contribution, but I've commented #3769 for some reason the gjson does not support json.Unmarshaler.

@gqcn gqcn closed this Sep 12, 2024
@gqcn gqcn added the rejected The proposal or PR is not accepted, which might be conflicted with our design or plan. label Sep 12, 2024
@wlynxg wlynxg deleted the gjson branch October 29, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rejected The proposal or PR is not accepted, which might be conflicted with our design or plan.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

encoding/gjson: UnmarshalJSON of dst not called
2 participants
@wlynxg @gqcn