enable canonicalheader linter in golangci-lint #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ccoVeille
commented
Jan 18, 2025
ccoVeille
commented
- ci: enable canonicalheader in golangci-lint
- chore: use canonical form for all HTTP headers
ccoVeille
force-pushed
the
golangci-canonicalheader
branch
2 times, most recently
from
18a6b10 to
23f7c5d
Compare
|
@ccoVeille Please resolve the merge conflicts in your branch. |
|
I will, but later today. I'm at work, I only contribute OSS projects on my free time. |
ccoVeille
force-pushed
the
golangci-canonicalheader
branch
from
23f7c5d to
e9c1773
Compare
|
Here it is, a simple conflict resolution |
This commit enables the canonicalheader linter in golangci-lint. This linter checks that all headers are in canonical format. The idea is to have a consistent way of writing headers in the codebase.
This follows the activation of canonicalheader linter in golangci-lint.
ccoVeille
force-pushed
the
golangci-canonicalheader
branch
from
e9c1773 to
b863c5a
Compare
Umang01-hash
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.