Add SurrealDB datasource support #1361

vaidehiadhi · 2025-01-04T15:26:01Z

Pull Request Template

Description:

i have added surrealDB datasource support to gofr following the previous datasource implementation as an example
closes the issue Add support for SurrealDB Add support for SurrealDB #1348

Additional Information:

i am running docker locally and then connecting it to the surrealDB database.
this is the docker command
surreal sql --conn ws://localhost:8000 --user root --pass root
Checklist:
I have formatted my code using goimport and golangci-lint.
All new code is covered by unit tests.
This PR does not decrease the overall code coverage.
I have reviewed the code comments and documentation for clarity.

Thank you for your contribution!

docs/advanced-guide/injecting-databases-drivers/page.md

pkg/gofr/datasource/surrealdb/surrealDB.go

Merging chnages

merging branch to the changed code with has tests without suits

pkg/gofr/external_db.go

docs/advanced-guide/injecting-databases-drivers/page.md

pkg/gofr/datasource/surrealdb/interface.go

pkg/gofr/datasource/surrealdb/surrealdb.go

merging the reviewed code

pkg/gofr/datasource/surrealdb/utils.go

docs/advanced-guide/injecting-databases-drivers/page.md

pkg/gofr/datasource/surrealdb/surrealdb.go

pkg/gofr/external_db.go

pkg/gofr/datasource/surrealdb/surrealdb_test.go

pkg/gofr/datasource/surrealdb/interface.go

docs/advanced-guide/injecting-databases-drivers/page.md

fixed pr conflicts

docs/advanced-guide/injecting-databases-drivers/page.md

pkg/gofr/container/datasources.go

pkg/gofr/datasource/surrealdb/interface.go

pkg/gofr/datasource/surrealdb/surrealdb.go

merging code

pkg/gofr/datasource/surrealdb/surrealdb.go

pkg/gofr/container/datasources.go

pkg/gofr/datasource/surrealdb/surrealdb.go

ccoVeille · 2025-01-17T08:33:37Z

BTW @vaidehiadhi thank you for baring with my reviews, feedbacks and questions.

I appreciate

merging changes

pkg/gofr/datasource/surrealdb/surrealdb.go

merge changes

added review comments

pkg/gofr/datasource/surrealdb/surrealdb.go

vaidehiadhi added 2 commits January 2, 2025 19:05

surrealDB implementation

8e41e54

added surrealDB support

edb4080

ccoVeille reviewed Jan 4, 2025

View reviewed changes

Umang01-hash and others added 7 commits January 6, 2025 16:20

Merge branch 'development' into surrealdb

56ce727

resolved review suggestions

0419cd4

Merge branch 'surrealdb' of github.com:vaidehiadhi/gofr into surrealdb

58cd998

Merging chnages

Merge branch 'development' into surrealdb

544d83f

changed code to write tests using mocks instead of suits

ebbc196

Merge branch 'surrealdb' of github.com:vaidehiadhi/gofr into surrealdb

f1d7257

merging branch to the changed code with has tests without suits

Merge branch 'development' into surrealdb

52dd1d9

coolwednesday suggested changes Jan 8, 2025

View reviewed changes

vaidehiadhi added 3 commits January 8, 2025 14:41

changed code according to the review suggestions

474ad37

Merge branch 'surrealdb' of github.com:vaidehiadhi/gofr into surrealdb

eaae9bb

merging the reviewed code

resolved linters

892e811

ccoVeille reviewed Jan 8, 2025

View reviewed changes

pkg/gofr/datasource/surrealdb/utils.go Outdated Show resolved Hide resolved

pkg/gofr/datasource/surrealdb/utils.go Outdated Show resolved Hide resolved

docs/advanced-guide/injecting-databases-drivers/page.md Outdated Show resolved Hide resolved

fixed linters

dbf2e52

coolwednesday suggested changes Jan 9, 2025

View reviewed changes

coolwednesday reviewed Jan 9, 2025

View reviewed changes

docs/advanced-guide/injecting-databases-drivers/page.md Outdated Show resolved Hide resolved

Umang01-hash and others added 4 commits January 13, 2025 11:30

Merge branch 'development' into surrealdb

2978005

resolved pr conflicts

44318e8

Merge branch 'surrealdb' of github.com:vaidehiadhi/gofr into surrealdb

ee1cadb

fixed pr conflicts

fixed documentation

44911ef

ccoVeille reviewed Jan 15, 2025

View reviewed changes

Umang01-hash and others added 4 commits January 16, 2025 10:57

Merge branch 'development' into surrealdb

7e4775e

resolved pr comments

753373f

Merge branch 'surrealdb' of github.com:vaidehiadhi/gofr into surrealdb

d44e7aa

merging code

added traces support

e2aac2e

ccoVeille reviewed Jan 16, 2025

View reviewed changes

resoved pr comments

bc5032c

ccoVeille reviewed Jan 17, 2025

View reviewed changes

pkg/gofr/datasource/surrealdb/surrealdb.go Outdated Show resolved Hide resolved

pkg/gofr/container/datasources.go Show resolved Hide resolved

pkg/gofr/datasource/surrealdb/surrealdb.go Outdated Show resolved Hide resolved

vaidehiadhi and others added 4 commits January 17, 2025 15:20

add id parameter in update method

109325d

Merge branch 'development' into surrealdb

67b6350

resolve pr comments

d141722

Merge branch 'surrealdb' of github.com:vaidehiadhi/gofr into surrealdb

0e8d7b1

merging changes

ccoVeille reviewed Jan 20, 2025

View reviewed changes

pkg/gofr/datasource/surrealdb/surrealdb.go Outdated Show resolved Hide resolved

vaidehiadhi and others added 11 commits January 20, 2025 16:01

added docker command in contribution

8f2eb6d

fixed merge conflict

f577c5c

added docs and mod improvements

ee577c9

added missing files

61510f5

Merge branch 'development' into surrealdb

811ff1a

docker command

051ff35

Merge branch 'surrealdb' of github.com:vaidehiadhi/gofr into surrealdb

78eb773

merge changes

docker command

7e99bcd

Merge branch 'development' into surrealdb

7bdc615

review suggestions

1279fe2

Merge branch 'surrealdb' of github.com:vaidehiadhi/gofr into surrealdb

5225086

added review comments

coolwednesday suggested changes Jan 21, 2025

View reviewed changes

pkg/gofr/datasource/surrealdb/surrealdb.go Outdated Show resolved Hide resolved

pkg/gofr/datasource/surrealdb/surrealdb.go Outdated Show resolved Hide resolved

vaidehiadhi added 3 commits January 21, 2025 16:41

review comments and linters

0e4cb34

removed metrics

4c20be9

resolved review comments

b8ea649

coolwednesday approved these changes Jan 21, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add SurrealDB datasource support #1361

Add SurrealDB datasource support #1361

vaidehiadhi commented Jan 4, 2025 •

edited

Loading

ccoVeille commented Jan 17, 2025

Add SurrealDB datasource support #1361

Are you sure you want to change the base?

Add SurrealDB datasource support #1361

Conversation

vaidehiadhi commented Jan 4, 2025 • edited Loading

Pull Request Template

ccoVeille commented Jan 17, 2025

vaidehiadhi commented Jan 4, 2025 •

edited

Loading