Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🩹 fix: Close File After SaveFileToStorage #3197

Merged
merged 4 commits into from
Nov 12, 2024
Merged

🩹 fix: Close File After SaveFileToStorage #3197

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21224dd
fix: close file after opening in SaveFileToStorage to prevent resourc…
gopkg-dev Nov 11, 2024
0b29269
♻️ refactor: simplify file close logic
gopkg-dev Nov 11, 2024
f7bce35
Merge branch 'main' into fix/file-upload-bug
gopkg-dev Nov 11, 2024
0c47452
Update ctx.go
gaby Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ctx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1470,6 +1470,7 @@
if err != nil {
return fmt.Errorf("failed to open: %w", err)
}
defer file.Close()

Check failure on line 1473 in ctx.go

View workflow job for this annotation

GitHub Actions / lint 

Error return value of `file.Close` is not checked (errcheck)
gopkg-dev marked this conversation as resolved.
Show resolved Hide resolved

content, err := io.ReadAll(file)
if err != nil {
Expand Down
Loading