v3: Refactor Benchmark Results Workflow #3082
Conversation
gaby
requested review from
sixcolors,
ReneWerner87 and
efectn
and removed request for
a team
|
Warning Rate limit exceeded@gaby has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 12 minutes and 48 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe changes enhance the GitHub Actions benchmark workflow by adding permissions for deployments and content management, enabling the publication of benchmark results to GitHub Pages. It improves data tracking by incorporating the SHA of the main branch and modifying cache keys based on the environment. The workflow also clarifies previous steps by renaming them and restricting certain actions to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/benchmark.yml (2 hunks)
Additional comments not posted (5)
.github/workflows/benchmark.yml (5)
12-16: Permissions section looks good.The added permissions for deployments and contents are necessary for publishing benchmark results to GitHub Pages and updating benchmark contents.
35-39: System information retrieval step looks good.Retrieving system information ensures that benchmark results are comparable across different environments.
40-52: SHA retrieval and caching steps look good.Retrieving the main branch SHA and caching benchmark results based on SHA, OS, and CPU model ensures accurate tracking and comparison of benchmarks.
68-99: Storing and publishing benchmark results steps look good.Storing benchmark results for the main branch and publishing them to GitHub Pages improve the visibility and management of benchmark outcomes.
100-105: Updating benchmark results cache step looks good.Updating the benchmark results cache for the main branch ensures that the latest results are cached for future comparisons.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3082 +/- ##
=======================================
Coverage 83.14% 83.14%
=======================================
Files 115 115
Lines 8332 8332
=======================================
Hits 6928 6928
Misses 1075 1075
Partials 329 329
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* Refactor benchmarks workflow * Use full semver tag * Add fetch depth
Description
SHAand the cpu-model.mainChanges introduced