Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Replace EG flag with the proper and smaller SVG #2585

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

scandar
Copy link
Contributor

@scandar scandar commented Aug 17, 2023

Description

Replaces the EG flag with a smaller SVG since the current one returns a 414 URI too big status code on Github

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • For new functionalities I follow the inspiration of the express js framework and built them similar in usage
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation - /docs/ directory for https://docs.gofiber.io/
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new dependencies exist, I have checked that they are really necessary and agreed with the maintainers/community (we want to have as few dependencies as possible)
  • I tried to make my code as fast as possible with as few allocations as possible
  • For new code I have written benchmarks so that they can be analyzed and improved

Comparison

Before

before

After

after

@ReneWerner87 ReneWerner87 merged commit 5fd3f20 into gofiber:master Aug 18, 2023
2 checks passed
@ReneWerner87
Copy link
Member

where did you find this flag?

@scandar
Copy link
Contributor Author

scandar commented Aug 18, 2023

@ReneWerner87 i made it

@ReneWerner87
Copy link
Member

ok i see^^
image

good work
since the flags are so small, no one will notice the difference

@scandar scandar deleted the replace-eg-arabic-flag branch August 18, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants