SCons: Enable werror for non-MSVC linkers#109312
Draft
Repiteo wants to merge 1 commit into
Draft
Conversation
Calinou
approved these changes
Aug 4, 2025
Calinou
left a comment
Calinou
left a comment
Member
There was a problem hiding this comment.
Tested locally on Fedora 42 + mold from system repositories, it works as expected (with werror=yes). Code looks good to me.
bruvzg
reviewed
Aug 5, 2025
Repiteo
force-pushed
the
scons/linker-werror
branch
6 times, most recently
from
8a2fdf7 to
47fc7fa
Compare
Repiteo
force-pushed
the
scons/linker-werror
branch
3 times, most recently
from
c4af768 to
f0c1c6c
Compare
Repiteo
force-pushed
the
scons/linker-werror
branch
from
f0c1c6c to
5005387
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
werrorsetting has always enabled warnings-as-errors for the compiler, but the linker has been applied inconsistently. Currently, only MSVC has linker warnings as errors in a universal manner; clang/gcc only enables them for web builds. This PR removes the web-specific implementation, instead applying it at a global level