Fix file path completion when projectile is used #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasPetton
force-pushed
the
master
branch
6 times, most recently
from
3f510de
to
5800457
Compare
When projectile is being used, `projectile-project-files' already returns file paths relative to the project root directory.
NicolasPetton
force-pushed
the
master
branch
2 times, most recently
from
4254182
to
7182675
Compare
|
I don't use projectile; let me ping another maintainer to review this. 🤔 cc @xiliuya Do you have any thoughts? |
|
@jcs090218 @xiliuya is there anything I can do to help with the review process? |
xiliuya
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When projectile is being used,
projectile-project-filesalready returns file paths relative to the project root directory, sogdscript-util--get-godot-project-file-path-relativeshould not be used.