Drop support for python 3.9 #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version went end of life on 31 October 2025; eliminating it simplifies support for existing versions. While we're twiddling, update tox.ini to disable pip installs of packages since we're using poetry anyway, and bump linters to use python 3.13 (vs 3.12).
...except on python 3.10, where support has been dropped upstream and we're already using the latest possible version. This fixes test errors I observed where python 3.14 tried to build the old pygit2 version itself (because no compatible wheel was available) and died because I didn't have the compiler et al on my test system.
We haven't changed the code, but pylint apparently is pickier now than it used to be and previously-accepted code has started failing. Disable the offending test because we do not want to be in the business of refactoring the code.
rbailey-godaddy
requested review from
emayuri-godaddy,
gebailey and
sushantmimani
It doesn't work well if we tell workflow "you must use 3.12" and tell tox "you must use 3.13". Update the workflow version to match.
gebailey
approved these changes
Nov 4, 2025
While we're modernizing everything else, push the docker base image from 3.11 to 3.13. Also fix capitalization of "AS" to squelch warning messages from docker regarding our inconsistent styling.
Duh. Co-authored-by: Sushant Mimani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help us get this pull request reviewed and merged quickly, please be sure to include the following items:
PR Type
What kind of change does this PR introduce?
Backward Compatibility
Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?
What's new?