Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Optimize the AddClusters function #789

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TestsLing
Copy link

@TestsLing TestsLing commented May 11, 2023

What type of PR is this?

optimize

What this PR does / why we need it:

When adding a cluster, the remaining clusters will not be interrupted, and it will return after the unified processing is completed, so that the error message can be returned for better positioning, and the related logic can be optimized

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@TestsLing TestsLing changed the title perf: 添加多个集群时全部处理完统一返回,优化相关代码 perf: Optimize the AddClusters function May 11, 2023
@github-actions
Copy link
Contributor

🎉 Successfully Build Images.
Now Support ARM Platforms.
Comment Post Time: 2023-05-11 15:29
Git Version: cecb769

Docker Registry

Overview: https://hub.docker.com/u/gocrane

Image Pull Command
crane-agent:pr-789-cecb769 docker pull gocrane/crane-agent:pr-789-cecb769
dashboard:pr-789-cecb769 docker pull gocrane/dashboard:pr-789-cecb769
metric-adapter:pr-789-cecb769 docker pull gocrane/metric-adapter:pr-789-cecb769
craned:pr-789-cecb769 docker pull gocrane/craned:pr-789-cecb769

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=gocrane/craned \
                   --set craned.image.tag=pr-789-cecb769 \
                   --set metricAdapter.image.repository=gocrane/metric-adapter \
                   --set metricAdapter.image.tag=pr-789-cecb769 \
                   --set craneAgent.image.repository=gocrane/crane-agent \
                   --set craneAgent.image.tag=pr-789-cecb769 \
                   --set cranedDashboard.image.repository=gocrane/dashboard \
                   --set cranedDashboard.image.tag=pr-789-cecb769 crane/crane

Coding Registry

Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages

Image Pull Command
crane-agent:pr-789-cecb769 docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-789-cecb769
dashboard:pr-789-cecb769 docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-789-cecb769
metric-adapter:pr-789-cecb769 docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-789-cecb769
craned:pr-789-cecb769 docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-789-cecb769

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
                   --set craned.image.tag=pr-789-cecb769 \
                   --set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-789-cecb769 \
                   --set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-789-cecb769 \
                   --set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-789-cecb769 crane/crane

Ghcr Registry

Overview: https://github.com/orgs/gocrane/packages?repo_name=crane

Image Pull Command
crane-agent:pr-789-cecb769 docker pull ghcr.io/gocrane/crane/crane-agent:pr-789-cecb769
dashboard:pr-789-cecb769 docker pull ghcr.io/gocrane/crane/dashboard:pr-789-cecb769
metric-adapter:pr-789-cecb769 docker pull ghcr.io/gocrane/crane/metric-adapter:pr-789-cecb769
craned:pr-789-cecb769 docker pull ghcr.io/gocrane/crane/craned:pr-789-cecb769

Quick Deploy - Helm

helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
                   --set craned.image.repository=ghcr.io/gocrane/crane/craned \
                   --set craned.image.tag=pr-789-cecb769 \
                   --set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
                   --set metricAdapter.image.tag=pr-789-cecb769 \
                   --set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
                   --set craneAgent.image.tag=pr-789-cecb769 \
                   --set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
                   --set cranedDashboard.image.tag=pr-789-cecb769 crane/crane

@qmhu
Copy link
Member

qmhu commented May 11, 2023

This pr optimize the code a little, but not enough, and also it's not a bugfix commit. So maybe not a bootcamp pr in my opinion.
The same problem as #780

@TestsLing
Copy link
Author

You can treat him as not a problem, or you can indicate in the project that you do not accept optimized pr submissions

@qmhu
Copy link
Member

qmhu commented May 12, 2023

You can treat him as not a problem, or you can indicate in the project that you do not accept optimized pr submissions

If your pr want to be a bootcamp pr, then should follow the guide, if not , i'd like to accept it if the code commit is right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants