Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : retry redirect to AlreadyVisitedUrl will loop error #826

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

fix : retry redirect to AlreadyVisitedUrl will loop error #826

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
93b2a30
retry redirect to AlreadyVisitedUrl will loop error
Shinku-Chen Apr 8, 2024
e1f73b6
retry redirect to AlreadyVisitedUrl will loop error
Shinku-Chen Apr 8, 2024
b27534c
retry redirect to AlreadyVisitedUrl will loop error
Shinku-Chen Apr 8, 2024
23e3a03
retry redirect to AlreadyVisitedUrl will loop error
Shinku-Chen Apr 8, 2024
8e80593
retry redirect to AlreadyVisitedUrl will loop error
Shinku-Chen Apr 8, 2024
9180983
retry redirect to AlreadyVisitedUrl will loop error
Shinku-Chen Apr 8, 2024
c9fd6cf
Merge branch 'gocolly:master' into master
Shinku-Chen Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
retry redirect to AlreadyVisitedUrl will loop error
@Shinku-Chen
Shinku-Chen committed Apr 8, 2024
commit b27534c4b657e8ccd8494dd9ceaf9f7dbe7ad338
3 changes: 1 addition & 2 deletions colly.go
View file
Original file line number Diff line number Diff line change
@@ -653,8 +653,7 @@ func (c *Collector) scrape(u, method string, depth int, requestData io.Reader, c
}
// note: once 1.13 is minimum supported Go version,
// replace this with http.NewRequestWithContext
//c.Context = context.WithValue(c.Context, CheckRevisitKey, checkRevisit)
req = req.WithContext(c.Context)
req = req.WithContext(context.WithValue(req.WithContext(c.Context).Context(), CheckRevisitKey, checkRevisit))
if err := c.requestCheck(parsedURL, method, req.GetBody, depth, checkRevisit); err != nil {
return err
}