-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check is the codes is formated in travis ci #864
base: master
Are you sure you want to change the base?
Conversation
For go's format rules, I think if we continues using "Merge pull request" button to merge PRs, it will make the master's codes been un-formatted again. I think we should using "Rebase" method to submit PRs, and rebase every PR before submit to avoid this. |
I saw goby is using go module and the old |
Codecov Report
@@ Coverage Diff @@
## master #864 +/- ##
=========================================
Coverage ? 80.92%
=========================================
Files ? 54
Lines ? 6775
Branches ? 0
=========================================
Hits ? 5483
Misses ? 1067
Partials ? 225
Continue to review full report at Codecov.
|
I understand the intention behind this change, but I don't feel the need to format all the code, especially not the vendor files. We use vendor because unlike normal applications, Goby's dependencies should be as steady as possible. And I want to minimize the risk that if a dependency is removed from the source, we won't be able to build our source code again. |
I saw current codes have not been formatted yet, so just added a travis ci step to check it, and I think this should work since this PR is failed now: https://travis-ci.org/github/goby-lang/goby/builds/738725791
I'll add another commit to format the codes and let CI pass again.