[WIP] #677 Ternary Expression Implementation #794
Conversation
| @@ -165,6 +165,14 @@ func (ti *TestableIdentifier) ShouldHaveName(expectedName string) { | |||
| } | |||
| } | |||
|
|
|||
| // TestableTernaryExpression | |||
There was a problem hiding this comment.
comment on exported type TestableTernaryExpression should be of the form "TestableTernaryExpression ..." (with optional leading article)
| @@ -262,6 +262,29 @@ func (n *NilExpression) String() string { | |||
| return "nil" | |||
| } | |||
|
|
|||
| type TernaryExpression struct { | |||
There was a problem hiding this comment.
exported type TernaryExpression should have comment or be unexported
| @@ -165,6 +165,14 @@ func (ti *TestableIdentifier) ShouldHaveName(expectedName string) { | |||
| } | |||
| } | |||
|
|
|||
| // TestableTernaryExpression | |||
There was a problem hiding this comment.
comment on exported type TestableTernaryExpression should be of the form "TestableTernaryExpression ..." (with optional leading article)
| } | ||
|
|
||
| func (te *TernaryExpression) expressionNode() {} | ||
| func (te *TernaryExpression) TokenLiteral() string { |
There was a problem hiding this comment.
exported method TernaryExpression.TokenLiteral should have comment or be unexported
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
==========================================
+ Coverage 80.3% 80.32% +0.02%
==========================================
Files 54 54
Lines 7417 7417
==========================================
+ Hits 5956 5958 +2
+ Misses 1234 1233 -1
+ Partials 227 226 -1
Continue to review full report at Codecov.
|
|
👍 Although I seldom find ternary expression useful (too hard to find 3 expressions all simple and short enough to put into the same line). I'm quite curious about what the implementation would be. |
|
@Maxwell-Alexius any update on this? |
I'm trying.
Issue #677