Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3076 #3114

Merged
merged 1 commit into from
Jun 18, 2022
Merged

Fix #3076 #3114

merged 1 commit into from
Jun 18, 2022

Conversation

9p4
Copy link
Contributor

@9p4 9p4 commented Jun 18, 2022

Details

Additional

Ideally there would be a test to check if an uppercased redirect URI would work but that would require for the OIDC testing Docker image to be changed, since the URL is hardcoded.

@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #3114 (b3c131b) into main (2298eb1) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3114      +/-   ##
==========================================
+ Coverage   92.02%   92.03%   +0.01%     
==========================================
  Files         466      466              
  Lines       20998    20998              
==========================================
+ Hits        19322    19324       +2     
+ Misses       1676     1674       -2     
Impacted Files Coverage Δ
authentik/providers/oauth2/views/token.py 83.27% <ø> (ø)
authentik/core/api/sources.py 83.55% <0.00%> (+2.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2298eb1...b3c131b. Read the comment docs.

@9p4
Copy link
Contributor Author

9p4 commented Jun 18, 2022

@BeryJu BeryJu merged commit 45364d6 into goauthentik:main Jun 18, 2022
@BeryJu
Copy link
Member

BeryJu commented Jun 18, 2022

@9p4 Ty for the PR, I think this is much easier tested with a unittest than with an e2e test, but I'll add that option to the oidc-test-client regardless

BeryJu added a commit that referenced this pull request Jun 18, 2022
BeryJu pushed a commit that referenced this pull request Jun 19, 2022
this was a leftover from before the migration regex checking for redirect URIs

closes #3076 and #3083
BeryJu added a commit that referenced this pull request Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants