[Testing] MogMogCheck v3.0.1 #5458
Conversation
|
Heya, first time submitting here. (Totally not shaking right now. My plan is to move the plugin to stable next week when the Moogle Tresure Trove starts. Regarding the plugin itself, I originally wrote it 2 years ago. It's a seasonal plugin, which means I only update it when a new Moogle Treasure Trove is about to start and a Dalamud API increase makes it mandatory to update it. Version 3.0.0 was a complete rewrite. I switched over to a modified Dalamud Table class, used a bunch new generators for dependency injection and generally had to update a bunch since my library changed a lot in the time the plugin last got an update. The plugin supports all game languages where possible (that means data from sheets, like item names and descriptions) and contains translations for the table headers, configuration window, command handler help text and context menus in English and German. I also made sure it works well with any UI scale and that everything is functional. So, I don't expect any feedback on my code. You can do that of course, but it'd be fine for me if you just look for any malicious stuff that I don't have.^^ Maybe I'll submit my other plugins in the futute! |
Head branch was pushed to by a user without write access
Outdated attemptThis is the first time that you have submitted a plugin here. Before the bot will build your plugin within the 'Build PR' check, someone from the approval team will need to enable builds for you. Once this is enabled, the bot will automatically build the PR. Future iterations will not require an approval for building the PR, only merging. Please hold! |
Haselnussbomber
changed the title
|
bleatbot, approve |
Outdated attemptAll builds OK! Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!
13 Needs (
|
| Type | Name | Version | Reviewed by |
|---|---|---|---|
| Submodule | https://github.com/Haselnussbomber/HaselCommon.git | 85982f6bc48b8a8a4165ebdd40bab8fe7b40e66f | |
| NuGet | AutoCtor | 2.5.0 | |
| NuGet | Injectio | 4.1.0 | |
| NuGet | Haselnussbomber.YogaSharp | 1.1.3 | |
| NuGet | System.Diagnostics.DiagnosticSource | 9.0.2 |
8 hidden needs (known safe NuGet packages).
Show log - Review
bleatbot
added
new plugin
This comment was marked as resolved.
This comment was marked as resolved.
|
All builds OK! Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!
12 Needs (
|
| Type | Name | Version | Reviewed by |
|---|---|---|---|
| Submodule | https://github.com/Haselnussbomber/HaselCommon.git | 85982f6bc48b8a8a4165ebdd40bab8fe7b40e66f | |
| NuGet | AutoCtor | 2.5.0 | |
| NuGet | Injectio | 4.1.0 | |
| NuGet | System.Diagnostics.DiagnosticSource | 9.0.2 |
8 hidden needs (known safe NuGet packages).
Show log - Review
reiichi001
added
completed-code-review
MogMogCheck is a small plugin to assist you in tracking the rewards of the Moogle Treasure Trove event (called Mog Mog Kollektion in German, hence the name).
Please note that the plugin reads the games shop data, which does not yet contain rewards for the Hunt for Phantasmagoria. Until Patch 7.18 is released, it will show rewards for the Hunt for Goetia.