This repository has been archived by the owner on Sep 7, 2021. It is now read-only.
This repository is currently being migrated. It's locked while the migration is in progress.
check driver.Valuer response, and skip the column if nil #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1167 +/- ##
=========================================
- Coverage 54.7% 54.7% -0.01%
=========================================
Files 42 42
Lines 7646 7648 +2
=========================================
+ Hits 4183 4184 +1
Misses 2935 2935
- Partials 528 529 +1
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1167 +/- ##
=========================================
- Coverage 54.7% 54.7% -0.01%
=========================================
Files 42 42
Lines 7646 7648 +2
=========================================
+ Hits 4183 4184 +1
Misses 2935 2935
- Partials 528 529 +1
Continue to review full report at Codecov.
|
mei-rune
pushed a commit
to mei-rune/xorm
that referenced
this pull request
Apr 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Some sort of column are updated by nil always, when type for the column implements
driver.Valuerinterface and it'sValue()method returnnil. It should checkrequiredField.Solution:
Check the response value of
driver.Valuer.Value(), if it isniland notrequiredField, skip the column.