-
-
Notifications
You must be signed in to change notification settings - Fork 222
ci: use docker compose in gha #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 93ddf9b93-PR-1033Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
govulncheck errors will be addressed in: #1034 |
@iwpnd can you please get rid of the "merge" commit on this branch. I don't think it's needed and we typically don't have those as part of the git history. This is ready to merge after that. I can also force push to your branch if you prefer. |
Have I ever not rebased my PRs before merging @ARolek? 😏 |
8d40c39
to
d9fe004
Compare
Rebase will drop that is what I mean :) |
I don't think it will, but let's give it a go. I have changed your permissions so you should be able to "rebase and merge" this PR into |
Once we have the last review, yesss |
Approved! |
but @gdey is missing 😋 |
I'll look at it right now. Last time I check it was still a Draft. Thanks for the notification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love when we can drop redundancy!
Hm, still not authorized to merge. |
@iwpnd Can you try again. I added you as a core maintainer. |
description
Would like to merge this before #1032 @ARolek, to separate it contextually. 😄