fix: honor explicit zero retry wait and max wait times#1162
Open
leno23 wants to merge 1 commit into
Open
Conversation
Fixes go-resty#992 by treating min=max=0 as constant zero backoff instead of falling back to library defaults. Unset min still uses defaultWaitTime when max is non-zero. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #992
When both
SetRetryWaitTime(0)andSetRetryMaxWaitTime(0)are set, jitter backoff now uses a constant zero delay instead of replacing zeros with library defaults.Unset minimum wait (
0with a positive max) still maps todefaultWaitTimeas before.Test plan
go test -run 'TestRetryCoverage|TestClientRetry'explicit zero min and max yields zero delaysubtestMade with Cursor