Return ErrReaderNotSeekable instead of sending empty bodies on retry#1156
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v3 #1156 +/- ##
=======================================
Coverage 99.77% 99.78%
=======================================
Files 20 20
Lines 4049 4113 +64
=======================================
+ Hits 4040 4104 +64
Misses 6 6
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
@pior ping, any updates? |
pior
force-pushed
the
fix-retry-non-seekable
branch
from
592f83e to
4ef6055
Compare
jeevatkm
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we
SetBody()is called with a non-retriable reader, retries will be sent with empty body.A similar bug with the multipart reader was fixed in #1133.
The original discussion: #1127.
This PR follows the same logic: return
ErrReaderNotSeekableinstead of silently sending an empty body.Breaking: the actual text of
ErrReaderNotSeekableis changed to make the error generic,multipartis removed.