-
Notifications
You must be signed in to change notification settings - Fork 147
Expose access to Ops to avoid stringly typing downstream #172
base: master
Are you sure you want to change the base?
Conversation
3532253
to
b84fb2b
Compare
Codecov Report
@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 69.71% 69.72% +0.01%
==========================================
Files 48 48
Lines 5484 5486 +2
==========================================
+ Hits 3823 3825 +2
Misses 1317 1317
Partials 344 344
Continue to review full report at Codecov.
|
Signed-off-by: Silas Davis <[email protected]>
@@ -85,3 +85,7 @@ func New(code byte) (Op, error) { | |||
} | |||
return op, nil | |||
} | |||
|
|||
func Get(opcode byte) Op { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a doc string for this?
Might using https://github.com/golang/tools/blob/master/cmd/stringer/stringer.go |
Feel free to integrate stringer for Apologies for the confusion, what I meant was to add a doc comment to |
ping? |
Avoid this kind of sadness:
https://github.com/perlin-network/life/blob/master/compiler/ssa.go#L445-L454
with:
Signed-off-by: Silas Davis [email protected]