Skip to content

fix(admin): exit dev test queue producer loop when context is cancelled#38451

Merged
wxiaoguang merged 3 commits into
go-gitea:mainfrom
Kadajett:fix/admin-test-queue-hot-spin
Jul 15, 2026
Merged

fix(admin): exit dev test queue producer loop when context is cancelled#38451
wxiaoguang merged 3 commits into
go-gitea:mainfrom
Kadajett:fix/admin-test-queue-hot-spin

Conversation

@Kadajett

Copy link
Copy Markdown
Contributor

The dev-mode test queue producer goroutine's select had an empty <-ctx.Done() case with no return. Once the context is cancelled, that case is permanently ready, so the loop busy-spins and allocates a new time.After timer on every iteration instead of exiting. Add the missing return so the goroutine stops on shutdown.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 14, 2026
@Kadajett

Copy link
Copy Markdown
Contributor Author

Also Hi! This is my first contribution! I am just going on a bug hunt on OSS that my friends recommend!

This is the only one that caught my eye initially, as someone who doesn't know the software super well yet!

Its a slam dunk, but on one of those child-sized basketball nets lol

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 15, 2026
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 15, 2026
@wxiaoguang wxiaoguang enabled auto-merge (squash) July 15, 2026 03:06
@wxiaoguang wxiaoguang merged commit 9fa2bff into go-gitea:main Jul 15, 2026
23 checks passed
@GiteaBot GiteaBot added this to the 28.0.0 milestone Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants