fix(admin): exit dev test queue producer loop when context is cancelled#38451
Merged
wxiaoguang merged 3 commits intoJul 15, 2026
Conversation
Contributor
Author
|
Also Hi! This is my first contribution! I am just going on a bug hunt on OSS that my friends recommend! This is the only one that caught my eye initially, as someone who doesn't know the software super well yet! Its a slam dunk, but on one of those child-sized basketball nets lol |
wxiaoguang
approved these changes
Jul 15, 2026
lunny
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dev-mode test queue producer goroutine's
selecthad an empty<-ctx.Done()case with noreturn. Once the context is cancelled, that case is permanently ready, so the loop busy-spins and allocates a newtime.Aftertimer on every iteration instead of exiting. Add the missingreturnso the goroutine stops on shutdown.