Skip to content

Refactor file-view toggle button visibility logic #34931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kerwin612
Copy link
Member

Move the visibility control of file-view-toggle-buttons to the backend template.
Frontend now only updates button state if the group exists.
This avoids UI flicker and keeps logic clear.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 2, 2025
@github-actions github-actions bot added modifies/templates This PR modifies the template files modifies/frontend labels Jul 2, 2025
@silverwind
Copy link
Member

Less flicker is always welcome :)

@wxiaoguang
Copy link
Contributor

But it is not right

@wxiaoguang wxiaoguang marked this pull request as draft July 2, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/frontend modifies/templates This PR modifies the template files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants