Skip to content

Move organization's visibility change to danger zone. #34814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Move organization's visibility change to danger zone. #34814

wants to merge 4 commits into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 21, 2025

image

image

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jun 21, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 21, 2025
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jun 21, 2025
@lunny lunny mentioned this pull request Jun 21, 2025
Open
wxiaoguang
wxiaoguang reviewed Jun 22, 2025
View reviewed changes
wxiaoguang
wxiaoguang reviewed Jun 22, 2025
View reviewed changes
@lunny lunny marked this pull request as draft June 22, 2025 17:35
@lunny lunny marked this pull request as ready for review July 1, 2025 19:01
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 3, 2025
@lunny lunny requested a review from wxiaoguang July 5, 2025 00:11
wxiaoguang
wxiaoguang reviewed Jul 5, 2025
View reviewed changes
models/user/user.go
@@ -955,6 +955,16 @@ func UpdateUserCols(ctx context.Context, u *User, cols ...string) error {
return err
}

// UpdateUserColsWithNoAutotime update user according special columns
func UpdateUserColsWithNoAutotime(ctx context.Context, u *User, cols ...string) error {
Copy link
Contributor

@wxiaoguang wxiaoguang Jul 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC you called other functions like UpdateRepositoryColsNoAutoTime, but not UpdateRepositoryColsWithNoAutotime

wxiaoguang
wxiaoguang reviewed Jul 5, 2025
View reviewed changes
modules/structs/visible_type.go
@@ -56,3 +60,10 @@ func ExtractKeysFromMapString(in map[string]VisibleType) (keys []string) {
}
return keys
}

func ConvertStringToVisibleType(s string) VisibleType {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang left review comments

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @wxiaoguang @hiifong @GiteaBot