Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 32 bit support to binser #17

Merged
merged 1 commit into from
May 24, 2022
Merged

Conversation

axhav
Copy link
Contributor

@axhav axhav commented May 21, 2022

Binser can now read and write archives writen by a boost program compiled with 32-bit.
Decided to add a new constructor to decoder/encoder/rbuffer/wbuffer to keep backwards compatability.
New tests can probably be structured in a better way, so feel free to give some input in improvements in that regard.

Also updated boost archive versions from 11 to 13 in constant Version and testdata archives.

Binser can now read and write archives writen by a boost program compiled with 32-bit
Also updated boost version from 11 to 13
Copy link
Collaborator

@sbinet sbinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR.

LGTM.

could you please send another PR, adding yourself to the AUTHORS and/or CONTRIBUTORS files?
thanks again.

@axhav
Copy link
Contributor Author

axhav commented May 23, 2022

Thanks! I created a new pull request (#20) with an update to contributors.

@sbinet sbinet mentioned this pull request May 24, 2022
@sbinet sbinet merged commit 5f8da08 into go-boostio:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants